fix(chromium): fix crash if connecting to a browser with a serviceworker #5803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Mar 11, 2021
src/server/chromium/crBrowser.ts
Outdated
| // are created automatically and may be initialized before we enable auto-attach. | ||
| // Their service workers are also automatically created, but setAutoAttach attaches to them. |
JoelEinbinder
force-pushed
the
auto_attach_twice
branch
from
7cd661f to
7b24363
Compare
|
@dgozman you suggested just deleting all the Target.setDiscoverTargets code. It appears to work! ptal |
dgozman
approved these changes
Mar 12, 2021
yury-s
reviewed
Mar 12, 2021
| @@ -59,32 +62,11 @@ export class CRBrowser extends Browser { | |||
| } | |||
| browser._defaultContext = new CRBrowserContext(browser, undefined, options.persistent); | |||
|
|
|||
| const existingTargetAttachPromises: Promise<any>[] = []; | |||
| // First page, background pages and their service workers in the persistent context | |||
| // are created automatically and may be initialized before we enable auto-attach. | |||
There was a problem hiding this comment.
How can we be sure that scenario mentioned in the comment is still handled correctly?
There was a problem hiding this comment.
There are new tests for what's described in this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target.setAutoAttachappears to connect to service workers again, which causes us to crash with duplicate target errors. Also service workers that were created before connecting to the browser were incorrectly dispatched to the client layer.Fixes #5648